performance issue in C++ codility challenge -

-

edit: problem algorithmic ( molbdnilo below answer ) failing case o(n2) --> quadratic. people below trying find true worst case o( n log(n) ) time complexity algorithm.

i took codility challenge month. took me hour have 100% correct o( n log(n) ) time complexity algorithm.

but can see in below got 75% in performance, because 1 of test took 10 times long run. , not why! could point me mistakes ?

  1. https://codility.com/cert/view/
  2. https://codility.com/cert/view/certd6ztbr-rjtnqe24v242yrcv/details

point 2 contains complete problem description , complete reports (test cases , timing) solution.

roughly, add each rope after , update path root (ancestors) added node position, new maximum weight can added "under/below" each ancestors.

here code:

    // can use includes, example:     #include <algorithm>     #include <vector>     #include <map>     #include <iostream>      using namespace std;     // can write stdout debugging purposes, e.g.     // cout << "this debug message" << endl;       struct node     {         int max_to_add;         int id;         node* mummy;     };      std::map< int, node* > nodes;      bool insertrope( int durability, int pos, int id, int weight )     {         node* n = new node;         n->id = id;         nodes[id] = n;          if( pos == -1 )         {             n->max_to_add = durability - weight;             n->mummy = null;             if( n->max_to_add < 0 ) return false;         }         else         {             std::map< int, node* >::iterator = nodes.find(pos);             if( != nodes.end() )             {                 node* parent = (*it).second;                  n->mummy = parent;                 n->max_to_add = std::min( ( parent->max_to_add - weight),  (durability - weight) ) ;                 if( n->max_to_add < 0 ) return false;                  node* current = n;                 while ( (current = current->mummy) != null )                 {                     current->max_to_add = current->max_to_add - weight;                     if( current->max_to_add < 0 )                      {                         return false;                     }                 }             }          }         return true;     }      int solution(vector<int> &a, vector<int> &b, vector<int> &c) {         // write code in c++11          for(int = 0; < a.size() ; ++i)          {             if( insertrope( a[i], c[i],i,b[i] ) == false ) {return i;}          }          return a.size();     }      int main()     {          /*static const int arra[] = {4, 3, 1};         vector<int> veca (arra, arra + sizeof(arra) / sizeof(arra[0]) );          static const int arrb[] = {2, 2, 1};         vector<int> vecb (arrb, arrb + sizeof(arrb) / sizeof(arrb[0]) );           static const int arrc[] = {-1, 0, 1};         vector<int> vecc (arrc, arrc + sizeof(arrc) / sizeof(arrc[0]) );         */           static const int arra[] = {5, 3, 6, 3, 3};         vector<int> veca (arra, arra + sizeof(arra) / sizeof(arra[0]) );          static const int arrb[] = {2, 3, 1, 1, 2};         vector<int> vecb (arrb, arrb + sizeof(arrb) / sizeof(arrb[0]) );           static const int arrc[] = {-1, 0, -1, 0, 3};         vector<int> vecc (arrc, arrc + sizeof(arrc) / sizeof(arrc[0]) );          int sol = solution(veca,vecb,vecc);          system("pause");         return 0;     }

edit 1: following rafid suggestion used new[], better, still have perf issue: https://codility.com/cert/view/certrt5ydp-w65hgpf28b5rn5ay/details

one performance tip can point out is: avoid using 'new' operator repeatedly expensive. can create large block of memory start , use whenever need don't allocate memory in heap repeatedly.


Comments

Post a Comment

Popular posts from this blog

matlab - "Contour not rendered for non-finite ZData" -

-
i'm trying plot frequency characteristic equation using ezplot, matlab gives following warning, "contour not rendered non-finite zdata". have used command plot frequency equations warning , plot display empty , not change axis range well. can please help. appreciated. here's code i'm using. % transfer matrix case-i, thin rotor clear all; clc; ei = 1626; l = 0.15; m = 0.44108; = 2.178*10^-4; i_p = 2.205*10^-5; itr = 0.24; i_pr = 0.479; syms p n; f = [1 l*1i l^2/(2*ei)*1i l^3/(6*ei); 0 1 l/ei -l^2/(2*ei)*1i; 0 0 1 -l*1i; 0 0 0 l]; p = [ 1 0 0 0; 0 1 0 0; 0 -it*p^2+i_p*n*p 1 0; -m*p^2 0 0 1]; p_r = [1 0 0 0; 0 1 0 0; 0 -itr*p^2+i_pr*n*p 1 0; -m*p^2 0 0 1]; = f*p*f*p*f*p*f; b = p_r*f*p*f*p*f; r = a(1,2)/a(1,4); a12_p = 0; a22_p = a(2,2)-r*a(2,4); a32_p = a(3,2)-r*a(3,4); a42_p = a(4,2)-r*a(4,4); ap(2,2) = a22_p; ap(3,2) = a32_p; ap(4,2) = a42_p; ap(4,4) = 1; c = b*ap; m = [c(3,2) c(3,4); c(4,2) c(4,...
Read more

delphi - Indy UDP Read Contents of Adata -

-
i using indy udp server read string of data. however, not know how work adata parameter. can around converting binary using bytetobin function below , convert hex using bintohex1 . feel stupid , works slow. know how can directly results without 2 conversions? thanks!! here codes: procedure tform1.idudpserver1udpread(athread: tidudplistenerthread; const adata: tidbytes; abinding: tidsockethandle); var buf: tidbytes; buffer: string; data_received: string; begin if bytestostring(adata) <> 'hello' begin buffer := hextostring('00'); setlength(buf, length(buffer)); copytidstring(buffer, buf, 0); abinding.sendto(abinding.peerip, abinding.peerport, buf); data_received := bintohex1(bytetobin(adata[1]) + bytetobin(adata[2]) + bytetobin(adata[3]) + bytetobin(adata[4]) + bytetobin(adata[5]) + bytetobin(adata[6]) + bytetobin(adata[7]) + bytetobin(adata[8]) + bytetobin(adata[9]) + bytetobin(adata[10]) + bytetobin(adata[11...
Read more

javascript - Any ideas when Firefox is likely to implement lengthAdjust and textLength? -

-
any ideas when firefox implement lengthadjust andtextlength?..... working svg application. lengthadjust , textlength working fine in chrome not working in fire fox . <svg viewbox = "0 0 500 300" version = "1.1"> <defs> <path id="s3" d="m 10,90 q 100,15 200,70" /> </defs> <g> <text font-size = "20"> <textpath xlink:href="#s3" textlength="205"> short text</textpath> </text> <use xlink:href="#s3" fill="none" stroke="black" stroke-width="1"/> </g> </svg> this implemented in firefox text elements (not textpath or tspan) in case that's ok though can move attribute text element. <svg viewbox = "0 0 500 300" version = "1.1"> <defs> ...
Read more